1.1.0 - Add optional key argument to Collection::add method

This commit is contained in:
Daniel Winning 2025-04-12 15:11:06 +01:00
parent b638d684a2
commit d439a25084
5 changed files with 24 additions and 5 deletions

View file

@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [1.1.0] - 2025-04-12
### Added
- Add optional `key` argument to `AbstractCollection::add()` method
## [1.0.2] - 2025-04-10 ## [1.0.2] - 2025-04-10
### Changed ### Changed
- Increased unit test coverage to 100% - Increased unit test coverage to 100%

View file

@ -2,7 +2,7 @@
<div> <div>
<!-- Version Badge --> <!-- Version Badge -->
<img src="https://img.shields.io/badge/Version-1.0.2-blue" alt="Version 1.0.2"> <img src="https://img.shields.io/badge/Version-1.1.0-blue" alt="Version 1.1.0">
<!-- PHP Coverage Badge --> <!-- PHP Coverage Badge -->
<img src="https://img.shields.io/badge/PHP%20Coverage-100.00%25-green" alt="PHP Coverage 100.00%"> <img src="https://img.shields.io/badge/PHP%20Coverage-100.00%25-green" alt="PHP Coverage 100.00%">
<!-- License Badge --> <!-- License Badge -->

View file

@ -14,7 +14,7 @@
"scripts": { "scripts": {
"test": "php -d xdebug.mode=coverage ./vendor/bin/phpunit --testdox --colors=always --coverage-html coverage --coverage-clover coverage/coverage.xml --testdox-html coverage/testdox.html && npx badger --phpunit ./coverage/coverage.xml && npx badger --version ./composer.json && npx badger --license ./composer.json" "test": "php -d xdebug.mode=coverage ./vendor/bin/phpunit --testdox --colors=always --coverage-html coverage --coverage-clover coverage/coverage.xml --testdox-html coverage/testdox.html && npx badger --phpunit ./coverage/coverage.xml && npx badger --version ./composer.json && npx badger --license ./composer.json"
}, },
"version": "1.0.2", "version": "1.1.0",
"license": "MIT", "license": "MIT",
"require-dev": { "require-dev": {
"phpunit/phpunit": "^12.1" "phpunit/phpunit": "^12.1"

View file

@ -12,12 +12,18 @@ class AbstractCollection implements CollectionInterface
{ {
} }
public function add(mixed $item): void public function add(mixed $item, string $key = null): void
{ {
if (null === $item) { if (null === $item) {
return; return;
} }
if ($key) {
$this->items[$key] = $item;
return;
}
$this->items[] = $item; $this->items[] = $item;
} }

View file

@ -11,10 +11,10 @@ use PHPUnit\Framework\TestCase;
class CollectionTest extends TestCase class CollectionTest extends TestCase
{ {
#[DataProvider('addDataProvider')] #[DataProvider('addDataProvider')]
public function testAdd(array $startingItems, mixed $itemToAdd, array $expectedResult): void public function testAdd(array $startingItems, mixed $itemToAdd, array $expectedResult, string $key = null): void
{ {
$collection = new Collection($startingItems); $collection = new Collection($startingItems);
$collection->add($itemToAdd); $collection->add($itemToAdd, $key);
$this->assertEquals($expectedResult, $collection->toArray()); $this->assertEquals($expectedResult, $collection->toArray());
} }
@ -52,17 +52,26 @@ class CollectionTest extends TestCase
'startingItems' => ['A', 'B', 'C'], 'startingItems' => ['A', 'B', 'C'],
'itemToAdd' => 'D', 'itemToAdd' => 'D',
'expectedResult' => ['A', 'B', 'C', 'D'], 'expectedResult' => ['A', 'B', 'C', 'D'],
'key' => null,
], ],
[ [
'startingItems' => [], 'startingItems' => [],
'itemToAdd' => 1, 'itemToAdd' => 1,
'expectedResult' => [1], 'expectedResult' => [1],
'key' => null,
], ],
[ [
'startingItems' => [], 'startingItems' => [],
'itemToAdd' => null, 'itemToAdd' => null,
'expectedResult' => [], 'expectedResult' => [],
'key' => null,
], ],
[
'startingItems' => ['A' => 'A', 'B' => 'B', 'C' => 'C'],
'itemToAdd' => 'D',
'expectedResult' => ['A' => 'A', 'B' => 'B', 'C' => 'C', 'D' => 'D'],
'key' => 'D',
]
]; ];
} }